Skip to content

fix(web): restore missing brace in Tools tab HTMX-fallback path#378

Merged
ChuckBuilds merged 1 commit into
mainfrom
hotfix/tools-tab-missing-brace
Jun 30, 2026
Merged

fix(web): restore missing brace in Tools tab HTMX-fallback path#378
ChuckBuilds merged 1 commit into
mainfrom
hotfix/tools-tab-missing-brace

Conversation

@ChuckBuilds

@ChuckBuilds ChuckBuilds commented Jun 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • The else if (++tries > 100) block added by feat(web): add Tools tab and row address type display setting #373 was missing its closing } before }, 100) closed the setInterval arrow function
  • This produced a JavaScript SyntaxError that silenced the entire 1,400-line script block — including new EventSource(...) and all of the _statsOpenHandler/_statsErrorHandler registrations
  • Result: the connection-status indicator never transitioned away from its default "Disconnected" HTML for every user on the current build

One character inserted, restoring the structure to what existed before #373 added the tools branch:

                             }
+                        }
                     }, 100);

Test plan

  • Reload the web UI — connection badge should turn green within ~1 second
  • Click the Tools tab — content loads normally (HTMX path still works)
  • Confirm no JS errors in browser console on page load

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a JavaScript syntax issue in the tab-loading fallback flow, improving reliability when the main loading library is not yet available.
    • Ensured the fallback logic completes correctly after fetching content, helping prevent unexpected behavior during tab content loading.

@claude
fix(web): restore missing brace in Tools tab HTMX-fallback path
61715e1 
The `else if (++tries > 100)` block added by #373 was missing its
closing `}`, leaving the setInterval arrow function syntactically
unclosed. This caused a JS parse error that silenced the entire
1400-line script block — including the EventSource setup — so the
connection-status indicator never left its default "Disconnected"
state for all users after updating.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: efda38d2-72a8-4c97-b13e-46072e8d2f5b

📥 Commits

Reviewing files that changed from the base of the PR and between 8e5f665 and 61715e1.

📒 Files selected for processing (1)
  • web_interface/templates/v3/base.html
📝 Walkthrough

Walkthrough

A single missing closing brace is added at line 1941 of base.html to complete the setInterval fallback block inside loadTabContent(), fixing a JavaScript syntax error in the Alpine app() logic.

Changes

Syntax Fix

Layer / File(s) Summary
Close setInterval fallback block
web_interface/templates/v3/base.html		 Inserts the missing } to properly terminate the "tools" fetch error handler inside the loadTabContent() setInterval fallback path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: restoring a missing brace in the Tools tab HTMX fallback path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/tools-tab-missing-brace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

codacy-production Bot commented Jun 30, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ChuckBuilds ChuckBuilds merged commit c6ce332 into main Jun 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ChuckBuilds